DatabaseProcApplicationCreatedLinks
sybsystemprocssp_revokelogin  31 Aug 14Defects Dependencies

1     
2     create proc sp_revokelogin
3         @col1 varchar(60) = NULL
4     as
5     
6         declare @msg varchar(255)
7     
8         /* 
9         ** check if user has sso role, proc_role will also do auditing
10        ** if required. proc_role will also print error message if required.
11        */
12    
13        if (proc_role("sso_role") = 0)
14            return (1)
15    
16        dbcc iseadmin("revokelogin", @col1)
17    
18        /* if no error, report success */
19        if @@error = 0
20        begin
21            /*
22            ** 18070, "Access revoked."
23            */
24            exec sp_getmessage 18070, @msg output
25            print @msg
26            return (0)
27        end
28    
29        /* 
30        ** If there was an error, the specific message was already sent to client 
31        ** within the iseadmin() module.
32        */
33    
34        return (1)
35    
36    /* end of sp_revokelogin */
37    

DEFECTS
 MNER 3 No Error Check should check return value of exec 24
 MUCO 3 Useless Code Useless Brackets 13
 MUCO 3 Useless Code Useless Brackets 14
 MUCO 3 Useless Code Useless Brackets 26
 MUCO 3 Useless Code Useless Brackets 34
 MTR1 2 Metrics: Comments Ratio Comments: 44% 2
 MTR2 2 Metrics: Cyclomatic Complexity Cyclo: 2 = 2dec - 2exi + 2 2
 MTR3 2 Metrics: Query Complexity Complexity: 12 2

DEPENDENCIES
PROCS AND TABLES USED
calls proc sybsystemprocs..sp_getmessage  
   reads table sybsystemprocs..sysusermessages  
   reads table master..sysmessages (1)  
   reads table master..syslanguages (1)  
   calls proc sybsystemprocs..sp_validlang  
      reads table master..syslanguages (1)